Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle grpc/protobuf curl zlib ssl in release-5.3 (#3896) (#3901) (#3974) (#3987) #4369

Merged
merged 4 commits into from
Apr 22, 2022
Merged

Bundle grpc/protobuf curl zlib ssl in release-5.3 (#3896) (#3901) (#3974) (#3987) #4369

merged 4 commits into from
Apr 22, 2022

Conversation

LittleFall
Copy link
Contributor

@LittleFall LittleFall commented Mar 21, 2022 •
edited
Loading

the cherry-pick of #4211

What problem does this PR solve?

Issue Number: close #4196

Problem Summary:

What is changed and how it works?

Reference: grpc/grpc#23144

Change to use boringssl.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the potential crash issue that occurs when TLS is enabled

zanmato1984 and others added 2 commits March 21, 2022 21:52
@zanmato1984 @LittleFall
Bundle grpc/protobuf in tiflash (#3896)
a7a06a1 
Fully rename project to tiflash (#3901)

Conflicts:
	libs/libdaemon/cmake/find_unwind.cmake

Remove useless curl dependency (#3974)

Bundle all dependencies: zlib, openssl and curl (#3987)

Conflicts:
	contrib/poco

update contrib/poco

update ci/cd process

Signed-off-by: Zhigao Tong <tongzhigao@pingcap.com>

fix zlib-ng

Signed-off-by: Zhigao Tong <tongzhigao@pingcap.com>
@LittleFall
extra fix
086f76b
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 21, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • solotzg
  • zanmato1984

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 21, 2022
@LittleFall
Copy link
Contributor Author

/run-all-tests

@LittleFall
Copy link
Contributor Author

/run-integration-test

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 21, 2022

lines: 36.1% (43060 out of 119427)
branches: 5.4% (65963 out of 1221493)

@LittleFall
Copy link
Contributor Author

LittleFall commented Mar 21, 2022 •
edited
Loading

Test failed because the failpoint of tidb 5.3 image is broken, I have contacted the administrator for help.

docker run -d -p 10080:10080 -e'GO_FAILPOINTS=github.com/pingcap/tidb/server/enableTestAPI=return' hub.pingcap.net/qa/tidb:release-5.3-failpoint

curl 127.0.0.1:10080/fail/github.com/pingcap/tidb/server/enableTestAPI
404 page not found

update: done

@solotzg
Copy link
Contributor

solotzg commented Mar 22, 2022

/run-integration-test

solotzg
solotzg approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@solotzg solotzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 22, 2022
@CLAassistant
Copy link

CLAassistant commented Apr 1, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@pingcap pingcap deleted a comment from CLAassistant Apr 2, 2022
zanmato1984
zanmato1984 approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 11, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 22, 2022
@zanmato1984
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@zanmato1984: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 352aaff

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 22, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Apr 22, 2022

lines: 36.1% (43057 out of 119427)
branches: 5.4% (65961 out of 1221493)

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 22, 2022
@LittleFall
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@LittleFall: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2e846b8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 22, 2022
@ti-chi-bot ti-chi-bot merged commit ba1f109 into pingcap:release-5.3 Apr 22, 2022
@LittleFall LittleFall deleted the cherrypick/4196-in-5.3 branch April 22, 2022 06:59
@sre-bot
Copy link
Collaborator

sre-bot commented Apr 22, 2022

lines: 36.0% (42973 out of 119430)
branches: 5.4% (65864 out of 1221503)

@heibaijian heibaijian added this to the v5.3.2 milestone Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solotzg solotzg solotzg approved these changes

@zanmato1984 zanmato1984 zanmato1984 approved these changes

@SchrodingerZhu SchrodingerZhu Awaiting requested review from SchrodingerZhu

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
v5.3.2
Development

Successfully merging this pull request may close these issues.
8 participants
@LittleFall @ti-chi-bot @sre-bot @solotzg @CLAassistant @zanmato1984 @VelocityLight @heibaijian